From niloufar: security fix: DLL loading and extract path #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 4, 2019 21:09
Fixed an error message when decryption of wrong password failed. Added taint marks to file paths in archives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally from @niloufar at masamitsu-murase#28
English:
Fixed the problem that 7z.dll could not be loaded in Ruby 2.6 for Windows. Also includes support for Dll Preloading Attacks.
I changed the source installed by gem install seven_zip_ruby_am and easily confirmed the operation. Ruby used is RubyInstaller version ruby 2.6.5p114 (2019-10-01 revision 67812) [x64-mingw32].
Secure loading of libraries to prevent DLL preloading attacks https://support.microsoft.com/en-us/help/2389418/secure-loading-of-libraries-to-prevent-dll-preloading-attacks